New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During bulk tracking, return indices of invalid requests #8296

Closed
diosmosis opened this Issue Jul 8, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@diosmosis
Member

diosmosis commented Jul 8, 2015

If invalid requests are detected during bulk tracking, it would be useful for the indices of these requests to be returned in the response. The log importer could then use this information to display the invalid log lines in a file to help facilitate debugging.

@diosmosis diosmosis added this to the 3.0.0 milestone Jul 8, 2015

@quba

This comment has been minimized.

Show comment
Hide comment
@quba

quba Jul 8, 2015

Contributor

👍

Contributor

quba commented Jul 8, 2015

👍

@diosmosis diosmosis self-assigned this Jul 8, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Jul 9, 2015

Member

It sounds very good idea to display at the end, all log lines that were "invalid". Maybe just before the summary (so the summary is still at very end, in case there are hundreds of invalid log lines) ?

Member

mattab commented Jul 9, 2015

It sounds very good idea to display at the end, all log lines that were "invalid". Maybe just before the summary (so the summary is still at very end, in case there are hundreds of invalid log lines) ?

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Jul 9, 2015

Member

Sounds good to me

Member

diosmosis commented Jul 9, 2015

Sounds good to me

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Jul 16, 2015

Member

moved into 2.15.0 as it will help our colleagues to troubleshoot issues, so better not to wait for 3.0.0

Member

mattab commented Jul 16, 2015

moved into 2.15.0 as it will help our colleagues to troubleshoot issues, so better not to wait for 3.0.0

@mattab mattab modified the milestones: 2.15.0, 3.0.0 Jul 16, 2015

diosmosis added a commit that referenced this issue Sep 8, 2015

Merge pull request #8644 from piwik/8296_bulk_track_request_index
Fixes #8296, in BulkTracking output, return the index of each invalid request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment