New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email reports: print the full URL source / origin of report in the email body #8461

Closed
MagicFab opened this Issue Jul 29, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@MagicFab

MagicFab commented Jul 29, 2015

It would be useful to add information on where a report originated from (full URL / main URL / other) when reports are sent by email, possibly also in PDF properties.

This would help know the origin of reports for troubleshooting and management purposes.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 14, 2015

Member

👍 to add link to Piwik in the email.

It should also be do-able to add the info as a PDF property

maybe some users will want to disable displaying the Piwik URL, but we can wait to see if anyone requests this.

Member

mattab commented Aug 14, 2015

👍 to add link to Piwik in the email.

It should also be do-able to add the info as a PDF property

maybe some users will want to disable displaying the Piwik URL, but we can wait to see if anyone requests this.

@mattab mattab added the Enhancement label Aug 14, 2015

@mattab mattab added this to the 2.15.0 milestone Aug 14, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 19, 2015

Member

If I see correct current text is

Hello,
Please find in attached file your weekly report for $reportName.

So we'd add something like This report was sent from $piwikUrl. ?

Member

tsteur commented Aug 19, 2015

If I see correct current text is

Hello,
Please find in attached file your weekly report for $reportName.

So we'd add something like This report was sent from $piwikUrl. ?

@MagicFab

This comment has been minimized.

Show comment
Hide comment
@MagicFab

MagicFab Aug 19, 2015

Yes, link to the root URL of the Piwik site generating the report (not to piwik.org!).

MagicFab commented Aug 19, 2015

Yes, link to the root URL of the Piwik site generating the report (not to piwik.org!).

@tsteur tsteur self-assigned this Aug 20, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 20, 2015

Member

FYI: I tried to set custom properties/metadata in the generated PDF report for quite a while but didn't get it working. There is this method setExtraMP() to set custom metadata but I couldn't find a single example on what to set there: https://github.com/tcpdf-clone/tcpdf/blob/master/tcpdf.php#L9492 . It probably should be some kind of </df:RDF> elements... if it is important I can invest more time

Member

tsteur commented Aug 20, 2015

FYI: I tried to set custom properties/metadata in the generated PDF report for quite a while but didn't get it working. There is this method setExtraMP() to set custom metadata but I couldn't find a single example on what to set there: https://github.com/tcpdf-clone/tcpdf/blob/master/tcpdf.php#L9492 . It probably should be some kind of </df:RDF> elements... if it is important I can invest more time

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 20, 2015

Member

If adding as a PDF property, I think it would be better to add the URL to the PDF Producer element. Though this seems like it could be a security risk if the URL to Piwik is meant to be private? The file could be forwarded to someone who shouldn't know of the URL.

Member

diosmosis commented Aug 20, 2015

If adding as a PDF property, I think it would be better to add the URL to the PDF Producer element. Though this seems like it could be a security risk if the URL to Piwik is meant to be private? The file could be forwarded to someone who shouldn't know of the URL.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 20, 2015

Member

Here is how it looks like:

rpeort pdf

The file could be forwarded to someone who shouldn't know of the URL.

that's good point, maybe we should be careful with hiding the piwik url within document.

@MagicFab i'll close issue as done for now, thx for suggestion

Member

mattab commented Aug 20, 2015

Here is how it looks like:

rpeort pdf

The file could be forwarded to someone who shouldn't know of the URL.

that's good point, maybe we should be careful with hiding the piwik url within document.

@MagicFab i'll close issue as done for now, thx for suggestion

@mattab mattab closed this Aug 20, 2015

@mattab mattab changed the title from REF: add full URL source / origin of report in reports email template to email reports: add full URL source / origin of report in reports email template Aug 20, 2015

@mattab mattab changed the title from email reports: add full URL source / origin of report in reports email template to Email reports: print the full URL source / origin of report in the email body Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment