New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Piwik opt-out feature work on internet explorer 11 when third party cookies are disabled #8578

Closed
mattab opened this Issue Aug 14, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@mattab
Member

mattab commented Aug 14, 2015

Follows up #3135

Let's make the Opt-out iframe work on IE11 as well. It may be as "easy" as changing https://github.com/piwik/piwik/blob/icons/plugins/CoreAdminHome/OptOutManager.php#L153-154 and testing on IE11.

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 17, 2015

Member

What should be changed there in this line?

Member

tsteur commented Aug 17, 2015

What should be changed there in this line?

@mattab mattab modified the milestones: 2.15.0, 2.15.1 Aug 17, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 17, 2015

Member

Maybe we could use the "safari code path" for all browsers rather than just for safari?

(on safari, when opting out, Piwik opens a popup in a new window that set the cookie on the third party domain - which is slightly less good UX - but it would work in all browsers even when third party cookies may be disabled)

Member

mattab commented Aug 17, 2015

Maybe we could use the "safari code path" for all browsers rather than just for safari?

(on safari, when opting out, Piwik opens a popup in a new window that set the cookie on the third party domain - which is slightly less good UX - but it would work in all browsers even when third party cookies may be disabled)

@diosmosis diosmosis self-assigned this Aug 17, 2015

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 26, 2015

Member

@mattab I've managed to get the popup approach working on IE11, however the approach will break on every browser if a pop-up blocker is used.

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

Member

diosmosis commented Aug 26, 2015

@mattab I've managed to get the popup approach working on IE11, however the approach will break on every browser if a pop-up blocker is used.

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 31, 2015

Member

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

left a comment in related issue: #6505 (comment)

Member

mattab commented Aug 31, 2015

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

left a comment in related issue: #6505 (comment)

@mattab mattab modified the milestones: 2.15.0, 2.15.1 Aug 31, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab
Member

mattab commented Aug 31, 2015

PR: #8646

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 8, 2015

Member

Fixed in #8646 - you can test this is working in piwik 2.15.0-b5

Member

mattab commented Sep 8, 2015

Fixed in #8646 - you can test this is working in piwik 2.15.0-b5

@mattab mattab closed this Sep 8, 2015

@Cruiser13

This comment has been minimized.

Show comment
Hide comment
@Cruiser13

Cruiser13 Sep 8, 2015

Thanks, works like a charm in IE 11. No issue with popup blockers aswell.

Cruiser13 commented Sep 8, 2015

Thanks, works like a charm in IE 11. No issue with popup blockers aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment