New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reporting menu should not use the module= query param in the URL to determine the active menu section #8624

Closed
diosmosis opened this Issue Aug 22, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@diosmosis
Member

diosmosis commented Aug 22, 2015

If a plugin adds it's own page to an existing menu section (say, for example, to the Goals plugin), the menu will not be selected when the plugin's page is loaded. This is because Piwik will only activate/highlight the Goals plugin section if the module is 'Goals', but since the page is added by another plugin, the module will be different.

The menu JS should use another mechanism to figure out which menu section is currently active.

@diosmosis diosmosis added this to the 2.15.0 milestone Aug 22, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Aug 24, 2015

Member

FYI: For reporting menu it already works differently in 3.0 branch

Member

tsteur commented Aug 24, 2015

FYI: For reporting menu it already works differently in 3.0 branch

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Aug 24, 2015

Contributor

Is it necessary to fix it in 2.15 if it's already changed in 3.0 then?

Contributor

mnapoli commented Aug 24, 2015

Is it necessary to fix it in 2.15 if it's already changed in 3.0 then?

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Aug 24, 2015

Member

It is necessary if @mattab still thinks it is required to fix the problem affecting a new plugin. Probably a good idea either way for the LTS version.

Member

diosmosis commented Aug 24, 2015

It is necessary if @mattab still thinks it is required to fix the problem affecting a new plugin. Probably a good idea either way for the LTS version.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Aug 26, 2015

Member
Member

mattab commented Aug 26, 2015

diosmosis added a commit that referenced this issue Aug 30, 2015

Refs #8624, do not set the ID of link elements in the reporting menu …
…and query the IDs when detecting the active menu item, instead find the link w/ the appropriate parameters get the parent li element. Also, do not activate the menu item until all angular menu group dropdowns are rendered.

diosmosis added a commit that referenced this issue Sep 8, 2015

Refs #8624, do not set the ID of link elements in the reporting menu …
…and query the IDs when detecting the active menu item, instead find the link w/ the appropriate parameters get the parent li element. Also, do not activate the menu item until all angular menu group dropdowns are rendered.

@diosmosis diosmosis closed this in #8669 Sep 9, 2015

diosmosis added a commit that referenced this issue Sep 9, 2015

Merge pull request #8669 from piwik/8624_module_active_detect
Fixes #8624, rewrite the way menu.js detects the active menu item (don't set elements, look for links w/ the right URL)

@mattab mattab removed the c: Design / UI label Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment