New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method logAllContenBlocksOnPage to piwik.js that lets you debug which content blocks are on your page #8650

Closed
tsteur opened this Issue Aug 28, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Aug 28, 2015

While helping a user to figure out via no content impressions are shown in the UI ( http://forum.piwik.org/read.php?15,122599,129060 ) I noticed it would be very helpful to have a method that let's you get all detected content blocks. Either just the dom nodes or a JSON array containing all content blocks like

[{name: '...', target:'...', piece: "..."},...]

It could by default just log to the console via logAllContentImpressions()

@tsteur tsteur added the Enhancement label Aug 28, 2015

@tsteur tsteur added this to the 2.15.1 milestone Aug 28, 2015

@tsteur tsteur changed the title from Add method that let's you debug/analyze which content blocks are on your page to Add method to piwik.js that let's you debug/analyze which content blocks are on your page Aug 28, 2015

@tsteur tsteur changed the title from Add method to piwik.js that let's you debug/analyze which content blocks are on your page to Add method to piwik.js that let's you debug which content blocks are on your page Aug 28, 2015

@tsteur tsteur modified the milestones: 2.15.0, 2.15.1 Aug 28, 2015

@tsteur tsteur self-assigned this Aug 28, 2015

diosmosis added a commit that referenced this issue Aug 31, 2015

Merge pull request #8653 from piwik/8650
Fixes #8650, add method logAllContentBlocksOnPage to piwik.js JavaScript tracker that let's you debug which content blocks are on your page.
@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 17, 2015

Member

Notes from PR:

After merging I will document in JS Tracker: http://developer.piwik.org/api-reference/tracking-javascript and content tracking guide: http://developer.piwik.org/guides/content-tracking

Also, let's add the new method to dev changelog

Member

mattab commented Sep 17, 2015

Notes from PR:

After merging I will document in JS Tracker: http://developer.piwik.org/api-reference/tracking-javascript and content tracking guide: http://developer.piwik.org/guides/content-tracking

Also, let's add the new method to dev changelog

@mattab mattab reopened this Sep 17, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 21, 2015

Member

FYI: It was already in dev changelog

Member

tsteur commented Sep 21, 2015

FYI: It was already in dev changelog

tsteur added a commit to matomo-org/developer-documentation that referenced this issue Sep 21, 2015

tsteur added a commit to matomo-org/developer-documentation that referenced this issue Sep 21, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 21, 2015

Member

Done

Member

tsteur commented Sep 21, 2015

Done

@tsteur tsteur closed this Sep 21, 2015

@mattab mattab changed the title from Add method to piwik.js that let's you debug which content blocks are on your page to New method to piwik.js that let's you debug which content blocks are on your page Oct 13, 2015

@mattab mattab changed the title from New method to piwik.js that let's you debug which content blocks are on your page to New method logAllContenBlocksOnPage to piwik.js that lets you debug which content blocks are on your page Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment