New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking outgoing links other than http or https is broken #8722

Closed
sesom42 opened this Issue Sep 7, 2015 · 10 comments

Comments

Projects
None yet
5 participants
@sesom42

sesom42 commented Sep 7, 2015

I'm using the normal tracking code from Piwiks admin page with link tracking enabled. Outgoing links are normally recorded by Piwik. All fine.

But I also have links other than HTTP or HTTPS on my website, for example, rtp: // ... These links will be logged, but misrepresented on the Piwik page. They all appear as a link to the Piwik Dashboard. In the visitor profile these links as shown as "Page URL not defined". Screenshot attached.

screenshot-piwik tausys de 2015-09-07 11-11-49

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Sep 7, 2015

Member

I can confirm that behaviour.

Member

sgiehl commented Sep 7, 2015

I can confirm that behaviour.

@sgiehl sgiehl added the Bug label Sep 7, 2015

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Sep 7, 2015

Member

Piwik is currently checking for url-like links before tracking them.
https://github.com/piwik/piwik/blob/master/core/UrlHelper.php#L108
Tihs method is used therefore. So currently only ftp, news, http and https are correctly tracked. Everything else will be tracked as "undefined page url"

We have two options to solve this:
Extend the list, or add an config option to extend it?

Member

sgiehl commented Sep 7, 2015

Piwik is currently checking for url-like links before tracking them.
https://github.com/piwik/piwik/blob/master/core/UrlHelper.php#L108
Tihs method is used therefore. So currently only ftp, news, http and https are correctly tracked. Everything else will be tracked as "undefined page url"

We have two options to solve this:
Extend the list, or add an config option to extend it?

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 8, 2015

Member

They should be tracked and displayed IMO. We're not back in the 90's :) Especially in mobile apps deep linking is common (see eg https://en.wikipedia.org/wiki/Mobile_deep_linking) and one wants to probably track and see it

Member

tsteur commented Sep 8, 2015

They should be tracked and displayed IMO. We're not back in the 90's :) Especially in mobile apps deep linking is common (see eg https://en.wikipedia.org/wiki/Mobile_deep_linking) and one wants to probably track and see it

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 8, 2015

Member

adding to 2.15.0 as this should be a quick fix. Are there other protocols we should add like rtp:// that are commonly used on web pages?

Member

mattab commented Sep 8, 2015

adding to 2.15.0 as this should be a quick fix. Are there other protocols we should add like rtp:// that are commonly used on web pages?

@mattab mattab added this to the 2.15.0 milestone Sep 8, 2015

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Sep 8, 2015

Member

Guess there are dozens we could add. So I would suggest to make that configurable as some might be very special... even rtp:// might not be very common

Member

sgiehl commented Sep 8, 2015

Guess there are dozens we could add. So I would suggest to make that configurable as some might be very special... even rtp:// might not be very common

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 8, 2015

Member

Can we not just allow any during tracking? Configuring it seems not user friendly and alone in the Android world there probably > 100.000 different protocols (for deep linking).

I'm not sure why it is restricted so maybe someone can help me here?

Member

tsteur commented Sep 8, 2015

Can we not just allow any during tracking? Configuring it seems not user friendly and alone in the Android world there probably > 100.000 different protocols (for deep linking).

I'm not sure why it is restricted so maybe someone can help me here?

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Sep 8, 2015

Member

Guess that was just to avoid crap being tracked as action. Btw. the reports are afaik not able to handle such "links" correct aswell.

Member

sgiehl commented Sep 8, 2015

Guess that was just to avoid crap being tracked as action. Btw. the reports are afaik not able to handle such "links" correct aswell.

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 8, 2015

Member

We should at least track it, at least if we claim to be like a mobile app tracking tool etc. Re the reports not sure. I'd probably display it as it'd work if one views it from a mobile device or whatever (depending on the protocol). I don't think people expect them to work when they view it in the browser. Meaning we could display them and link them. If someone clicks on it and nothing happens or a blank window opens that could be okay. Maybe not :) I'd link them

Member

tsteur commented Sep 8, 2015

We should at least track it, at least if we claim to be like a mobile app tracking tool etc. Re the reports not sure. I'd probably display it as it'd work if one views it from a mobile device or whatever (depending on the protocol). I don't think people expect them to work when they view it in the browser. Meaning we could display them and link them. If someone clicks on it and nothing happens or a blank window opens that could be okay. Maybe not :) I'd link them

@sesom42

This comment has been minimized.

Show comment
Hide comment
@sesom42

sesom42 Sep 8, 2015

I think if link tracking is enabled, Piwik should record everything that is a link. Why else would anyone turn on link tracking? Whether then the links work in reports or dashboard is up to the platform on which they are looked at. When a Web page is displayed, the browser decides how the links contained are treated. A selection of recordable protocols I do not consider necessary. The author decides with the inclusion of a link on the webpage if there is a link or not.

sesom42 commented Sep 8, 2015

I think if link tracking is enabled, Piwik should record everything that is a link. Why else would anyone turn on link tracking? Whether then the links work in reports or dashboard is up to the platform on which they are looked at. When a Web page is displayed, the browser decides how the links contained are treated. A selection of recordable protocols I do not consider necessary. The author decides with the inclusion of a link on the webpage if there is a link or not.

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 8, 2015

Member

👍

Member

tsteur commented Sep 8, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment