New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the "Segmented Visitor Log" icon in Custom Variables report #8755

Closed
mattab opened this Issue Sep 11, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@mattab
Member

mattab commented Sep 11, 2015

Follows up #7212 - requires #6031

Let's display the Segmented Visitor Log icon in Custom Variables, this will be so very awesome feature!

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 16, 2015

Member

Added to the top level report in 237f202

It's not possible to add it subtables w/o requesting the top-level report in the subtable API method. This would be a performance hit so I'm moving this to 3.0.

For 3.0, we should make it possible for idSubtables to be the parent row's label, instead of just an integer ID. This would make it possible to get the row label within the subtable method and would increase performance in some cases when it is required to get a subtable by row, w/o having querying the parent table first.

Member

diosmosis commented Sep 16, 2015

Added to the top level report in 237f202

It's not possible to add it subtables w/o requesting the top-level report in the subtable API method. This would be a performance hit so I'm moving this to 3.0.

For 3.0, we should make it possible for idSubtables to be the parent row's label, instead of just an integer ID. This would make it possible to get the row label within the subtable method and would increase performance in some cases when it is required to get a subtable by row, w/o having querying the parent table first.

@diosmosis diosmosis modified the milestones: 3.0.0, 2.15.0 Sep 16, 2015

@mattab mattab modified the milestones: 2.15.0, 3.0.0 Sep 18, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 18, 2015

Member

Moving back to 2.15.0 - let's close this issue as this is already a new feature, we'll open a new one for the sub-tables icon.

Member

mattab commented Sep 18, 2015

Moving back to 2.15.0 - let's close this issue as this is already a new feature, we'll open a new one for the sub-tables icon.

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 18, 2015

Member

So then should this be closed?

Member

diosmosis commented Sep 18, 2015

So then should this be closed?

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 19, 2015

Member

When PR #7212 will be merged, yes

Member

mattab commented Sep 19, 2015

When PR #7212 will be merged, yes

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 22, 2015

Member

This enhancement already is useful, nice 👍

Will be followed up & improved further in #8837

Member

mattab commented Sep 22, 2015

This enhancement already is useful, nice 👍

Will be followed up & improved further in #8837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment