New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Evolution can fail when a segment is used #8776

Closed
mattab opened this Issue Sep 14, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@mattab
Member

mattab commented Sep 14, 2015

When a segment is used, opening row evolution and/or visitor profile does not work (in some cases)

Issue 1: row evolution

Reproduce:

Issue 2: visitor profile

I guess is the same issue:

Reproduce:

Suggested steps

  • Add UI test(s) to reproduce this issue (maybe we don't have a UI test for Row Evolution / Visitor profile with a segment set?)
  • Fix the issue

I didn't add Regression because this appears not to be a regression!

@mattab mattab added the Bug label Sep 14, 2015

@mattab mattab added this to the 2.15.0 milestone Sep 14, 2015

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 16, 2015

Member

This is caused by https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L354. For some reason broadcast.getHashFromUrl encodes the URL again. This results in setting the new URL to something different from broadcast.currentHashUrl (after the popover= query param is removed), so broadcast.pageload will not load the popover (https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L119). Trying to figure out why...

Member

diosmosis commented Sep 16, 2015

This is caused by https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L354. For some reason broadcast.getHashFromUrl encodes the URL again. This results in setting the new URL to something different from broadcast.currentHashUrl (after the popover= query param is removed), so broadcast.pageload will not load the popover (https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/broadcast.js#L119). Trying to figure out why...

@diosmosis diosmosis self-assigned this Sep 16, 2015

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 16, 2015

Member

Actually that's not quite right, it gets encoded again somewhere else...

Member

diosmosis commented Sep 16, 2015

Actually that's not quite right, it gets encoded again somewhere else...

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 16, 2015

Member

Caused by an angular bug, $location.absUrl() decodes url parameters (at least in the hash).

Member

diosmosis commented Sep 16, 2015

Caused by an angular bug, $location.absUrl() decodes url parameters (at least in the hash).

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 16, 2015

Member

Ok, not a bug with angular, it's because we use $location.path() to store hash query parameters. We should be using $location.search().

Member

diosmosis commented Sep 16, 2015

Ok, not a bug with angular, it's because we use $location.path() to store hash query parameters. We should be using $location.search().

@mattab mattab added the Major label Sep 22, 2015

@tsteur tsteur closed this in #8805 Sep 22, 2015

@mattab mattab changed the title from Clicking on Row Evolution, when a segment is set, can fail to Row Evolution can fail when a segment is used Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment