Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use current Login auth plugin instead of hard-coded 'Login' on the error page #8808
When an exception page is shown, it has following links underneath the exception message:
The issue is that that
There are following two options:
a. Replace the hard-coded
The disadvantage of the above approach (a) is that it makes the exception page dependent on more things which could possibly fail. I haven't checked, but that could result in the exception page failure to appear, if something goes wrong on login plugin name acquisition, throwing another exception (cascading exceptions resulting in an uncaught error output?).
So, here is a simple and safe option:
b. Remove the
What also speaks for this solution is the fact that the Login link is not really necessary. Because when a user clicks on
Either option is trivial to implement. I could submit a pull request, if it's decided which one to go with. BUT: I guess that that would cause a Travis "expected screenshot" test to fail due to the changed page appearance. And I won't be able to get a hold of the new image - see #8781 (comment).
Since there is also another