New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving plugin settings, disable the "Save" button to prevent double clicks #8811

Closed
mattab opened this Issue Sep 17, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@mattab
Member

mattab commented Sep 17, 2015

When saving plugin settings, we should disable the "Save" button to prevent double clicks. Otherwise user may get Cloud not verify the security token on this form and believe the form submission failed.

@mattab mattab added the c: Usability label Sep 17, 2015

@mattab mattab added this to the 2.15.0 milestone Sep 17, 2015

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Sep 17, 2015

Member

I'd suggest to do that global for all save buttons (where needed) maybe with a special class or data attribute. Doesn't make sense to find a new solution for every new save button ;)

Member

sgiehl commented Sep 17, 2015

I'd suggest to do that global for all save buttons (where needed) maybe with a special class or data attribute. Doesn't make sense to find a new solution for every new save button ;)

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 17, 2015

Member

Definitely!

Member

mattab commented Sep 17, 2015

Definitely!

@mgonera

This comment has been minimized.

Show comment
Hide comment
@mgonera

mgonera commented Sep 17, 2015

screencast 2015-09-17 12-01-42

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Sep 17, 2015

Member

This is what https://docs.angularjs.org/api/ng/directive/ngDisabled is for. Should use this instead of creating a non-angular solution. Though something that bridges jquery/angular will be needed for now.

Member

diosmosis commented Sep 17, 2015

This is what https://docs.angularjs.org/api/ng/directive/ngDisabled is for. Should use this instead of creating a non-angular solution. Though something that bridges jquery/angular will be needed for now.

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Oct 2, 2015

Member

We cannot really use ngDisabled here as there's not an angular component around this that unsets ngDisabled= once the request is done/failed. Ideally we would use it though I will see what is possible. Of course we can get the elements scope and reset it but that's a mess. Especially when multiple save buttons are registered in the root scope because they do not define their own scope.

Member

tsteur commented Oct 2, 2015

We cannot really use ngDisabled here as there's not an angular component around this that unsets ngDisabled= once the request is done/failed. Ideally we would use it though I will see what is possible. Of course we can get the elements scope and reset it but that's a mess. Especially when multiple save buttons are registered in the root scope because they do not define their own scope.

tsteur added a commit that referenced this issue Oct 2, 2015

@tsteur tsteur self-assigned this Oct 2, 2015

@sgiehl sgiehl closed this in #8895 Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment