Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visitor log can show visits from the week before before #9053

Open
hpvd opened this Issue Oct 19, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@hpvd
Copy link

commented Oct 19, 2015

when there is no visit within the selected week (e.g. it's Monday and very early) visitor log shows visits from week before. Seen in 2.15RC3
Please see attachment
Seems to be related to #8761

2015-10-19_14h06_47

@hpvd hpvd changed the title visitor log can show visits from the wwek before before visitor log can show visits from the week before before Oct 19, 2015

@tsteur

This comment has been minimized.

Copy link
Member

commented Oct 19, 2015

@mattab do you remember why this one was added: 3211d25#diff-11527d0f07d21b83277153a2ebb852ac ? I don't think it is needed and makes much sense anymore but it is still there: https://github.com/piwik/piwik/blob/master/plugins/Live/Model.php#L464-L470

@mattab

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

I think we probably can remove this code, but not in LTS: in 3.0 reelase

@tsteur tsteur added this to the 3.0.0-b1 milestone Oct 20, 2015

@tsteur tsteur added the Bug label Oct 20, 2015

tsteur added a commit that referenced this issue Sep 13, 2016

@tsteur tsteur self-assigned this Sep 13, 2016

mattab added a commit that referenced this issue Sep 20, 2016

@mattab

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

Fixed in: #10490

@mattab mattab closed this Sep 20, 2016

@mattab

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

We are reverting the PR #10490 because it regressed and created this bug: #11165

Right now I don't understand this, but fixing #11165 is currently more important than #9053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.