Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PHP max_execution_time; increase for one click updates #938

Closed
robocoder opened this issue Aug 16, 2009 · 3 comments
Closed

Check PHP max_execution_time; increase for one click updates #938

robocoder opened this issue Aug 16, 2009 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@robocoder
Copy link
Contributor

Recent reports of auto-update not completing. Most likely cause is max_execution_time being set too low. (Default on my box is 30s.)

  • we know fetchRemoteFile ranges from 6s via curl to 13s via socket
  • time how long it currently takes (typically) for unzipping and copying
  • add system check and warning to installer
  • one click update: warn if set too low; try to increase limit
@mattab
Copy link
Member

mattab commented Aug 17, 2009

I think it's fine to set it to unlimited during the one click update. This could be a static function in Piwik:: that we could also call from the archiving code (maybe this is already done?)

@robocoder
Copy link
Contributor Author

In [1407], refs #938 - add Piwik::setMaxExecutionTime()

@robocoder
Copy link
Contributor Author

In [1411], refs #938 - replace set_time_limit() with call to Piwik::setMaxExecutionTime().

In [1408#file3], call Piwik::setMaxExecutionTime(0) for one click update and command line database update.

(For archiving, defer to LaunchArchiving plugin.)

@robocoder robocoder added this to the Piwik 0.4.4 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants