Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB field name Screen resolution is too small: width and height should not be limited to 9999 pixels #9913

Closed
mattab opened this Issue Mar 10, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@mattab
Copy link
Member

commented Mar 10, 2016

The current resolution field is set to VARCHAR(9). This means that the field may be truncated if we store a resolution width or height more than 9999 pixels. Then the resolution wouldn't fit in 9 characters (they are stored separated by a x in log_visit.config_resolution).

Goal of this issue is to change the DB field type to allow for more characters, so one could track very large resolutions. (note that the integration test in RequestTest.php (and getResolution in Tracker/Request) will need to be updated, see https://github.com/piwik/piwik/pull/9914/files#diff-35f2659319670251c767de1da7cb514aR358)

follows up #9911

@mattab mattab added this to the 3.0.0-b1 milestone Mar 10, 2016

@tsteur

This comment has been minimized.

Copy link
Member

commented Mar 10, 2016

👍

@tsteur tsteur added the Bug label Sep 13, 2016

@tsteur tsteur self-assigned this Sep 13, 2016

tsteur added a commit that referenced this issue Sep 13, 2016

tsteur added a commit that referenced this issue Sep 13, 2016

Make resolution field bigger (#10489)
* fixes #9913 make resolution field bigger

* fix ui test

@tsteur tsteur closed this Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.