Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for windows phone 7 version 7.5 #1

Closed
wants to merge 2 commits into from
Closed

adding support for windows phone 7 version 7.5 #1

wants to merge 2 commits into from

Conversation

thirashima
Copy link

@thirashima thirashima commented Nov 11, 2011

UserAgentClass fails to return an OS for 7.5 user agent strings.

@robocoder robocoder closed this Jan 20, 2012
@robocoder
Copy link
Contributor

@robocoder robocoder commented Jan 20, 2012

We initially added detection specifically for Windows Phone 7.5 (in http://dev.piwik.org/trac/ticket/2808), but later decided to consolidate and drop the OS version (given market share, and general inconsistency; Windows desktop OS versions continue to be detected though). http://dev.piwik.org/trac/ticket/2824

mattab pushed a commit that referenced this issue Jun 2, 2014
cbonte added a commit to cbonte/piwik that referenced this issue Jun 2, 2014
As a reference on a laptop with :
Intel(R) Core(TM) i7-2630QM CPU @ 2.00GHz
Python 2.7.7rc1
Debian SID - Linux 3.14-1-amd64 matomo-org#1 SMP Debian 3.14.4-1 (2014-05-13) x86_64 GNU/Linux

The results are :
cache   : 647.914 ms
nocache : 21440.542 ms
@anonymous-matomo-user anonymous-matomo-user mentioned this pull request Jun 1, 2009
@halfdan halfdan mentioned this pull request Jul 1, 2009
@mikeSimonson mikeSimonson mentioned this pull request Aug 10, 2009
@lehrer lehrer mentioned this pull request Sep 16, 2010
sgiehl added a commit that referenced this issue Dec 16, 2021
/srv/matomo/plugins/UsersManager/Controller.php(669): Deprecated - md5(): Passing null to parameter #1 ($string) of type string is deprecated
sgiehl added a commit that referenced this issue Dec 16, 2021
Uncaught exception: TypeError: array_diff(): Argument #1 ($array) must be of type array, string given in /srv/matomo/plugins/CoreVisualizations/Visualizations/Sparklines.php:306
sgiehl added a commit that referenced this issue Dec 21, 2021
* fixes deprecation warning in ui-test.php

/srv/matomo/config/environment/ui-test.php(53): Deprecated - str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

* fixes deprecation warning caused by SettingsPiwik.php

/srv/matomo/plugins/UsersManager/Controller.php(669): Deprecated - md5(): Passing null to parameter #1 ($string) of type string is deprecated

* Fixes deprecation warning in ComparisonRowGenerator.php

/srv/matomo/plugins/API/Filter/DataComparisonFilter/ComparisonRowGenerator.php(129): Deprecated - Automatic conversion of false to array is deprecated

* Fixes type error in Sparklines.php

Uncaught exception: TypeError: array_diff(): Argument #1 ($array) must be of type array, string given in /srv/matomo/plugins/CoreVisualizations/Visualizations/Sparklines.php:306

* Fixes some warnings in DisablePluginArchive fixture

/srv/matomo/tests/PHPUnit/Fixtures/DisablePluginArchive.php(59): Warning - Undefined property: Piwik\Tests\Fixtures\DisablePluginArchive::$useThirdPartyCookies
/srv/matomo/tests/PHPUnit/Fixtures/DisablePluginArchive.php(74): Warning - Undefined property: Piwik\Tests\Fixtures\DisablePluginArchive::$useSiteSearch
/srv/matomo/tests/PHPUnit/Fixtures/DisablePluginArchive.php(75): Warning - Undefined property: Piwik\Tests\Fixtures\DisablePluginArchive::$useSiteSearch
/srv/matomo/tests/PHPUnit/Fixtures/DisablePluginArchive.php(76): Warning - Undefined property: Piwik\Tests\Fixtures\DisablePluginArchive::$useSiteSearch
/srv/matomo/tests/PHPUnit/Fixtures/DisablePluginArchive.php(132): Warning - Undefined property: Piwik\Tests\Fixtures\DisablePluginArchive::$useSiteSearch

* Fixes undefined array key warningin SitesManager.php

/srv/matomo/plugins/SitesManager/SitesManager.php(376): Warning - Undefined array key unknown
deybhayden added a commit to deybhayden/matomo that referenced this issue Mar 9, 2022
An error happens if sites if names or skus are arrays in PHP 8

> Uncaught exception in core/Tracker/GoalManager.php line 567:
> trim(): Argument matomo-org#1 ($string) must be of type string, array given
deybhayden added a commit to deybhayden/matomo that referenced this issue Mar 9, 2022
An error happens if sites if names or skus are arrays in PHP 8

> Uncaught exception in core/Tracker/GoalManager.php line 567:
> trim(): Argument matomo-org#1 ($string) must be of type string, array given
@deybhayden deybhayden mentioned this pull request Mar 9, 2022
11 tasks
sgiehl pushed a commit that referenced this issue Mar 11, 2022
* Fix PHP8 Trim Error

An error happens if sites if names or skus are arrays in PHP 8

> Uncaught exception in core/Tracker/GoalManager.php line 567:
> trim(): Argument #1 ($string) must be of type string, array given

* Add unit test for PHP8 trim fix
@philipjonsen philipjonsen mentioned this pull request May 7, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants