Skip to content

Conversation

@thirashima
Copy link

UserAgentClass fails to return an OS for 7.5 user agent strings.

@robocoder robocoder closed this Jan 20, 2012
@robocoder
Copy link
Contributor

We initially added detection specifically for Windows Phone 7.5 (in http://dev.piwik.org/trac/ticket/2808), but later decided to consolidate and drop the OS version (given market share, and general inconsistency; Windows desktop OS versions continue to be detected though). http://dev.piwik.org/trac/ticket/2824

mattab pushed a commit that referenced this pull request Jun 2, 2014
cbonte added a commit to cbonte/piwik that referenced this pull request Jun 2, 2014
As a reference on a laptop with :
Intel(R) Core(TM) i7-2630QM CPU @ 2.00GHz
Python 2.7.7rc1
Debian SID - Linux 3.14-1-amd64 matomo-org#1 SMP Debian 3.14.4-1 (2014-05-13) x86_64 GNU/Linux

The results are :
cache   : 647.914 ms
nocache : 21440.542 ms
@halfdan halfdan mentioned this pull request Jul 1, 2009
@mikeSimonson mikeSimonson mentioned this pull request Aug 10, 2009
@lehrer lehrer mentioned this pull request Sep 16, 2010
blankse added a commit to blankse/matomo that referenced this pull request Oct 18, 2023
blankse added a commit to blankse/matomo that referenced this pull request Oct 30, 2023
sgiehl added a commit that referenced this pull request Jan 4, 2024
… string is deprecated (#21413)

Co-authored-by: Stefan Giehl <stefan@matomo.org>
sgiehl added a commit that referenced this pull request Feb 13, 2024
sgiehl added a commit that referenced this pull request Feb 15, 2024
)

* [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.*

* Apply coding style around FunctionCallSignature #1 (#21927)

* Apply coding style around FunctionCallSignature #2 (#21928)

* Apply coding style around FunctionCallSignature #3 (#21929)

* Apply coding style around FunctionCallSignature #4 (#21930)

* Apply coding style around FunctionCallSignature #5 (#21931)

* Apply coding style around FunctionCallSignature #6 (#21932)

* Apply coding style around FunctionCallSignature #7 (#21933)

* Apply coding style around FunctionCallSignature #8 (#21934)

* Apply coding style around FunctionCallSignature #9 (#21935)
@9joshua 9joshua mentioned this pull request Apr 24, 2024
mbrodala added a commit to mbrodala/matomo that referenced this pull request Jan 28, 2025
The "idvisitor" property can be undefined/null, this must be taken into account to avoid this error:

> strlen(): Passing null to parameter matomo-org#1 ($string) of type string is deprecated in /.../core/Tracker/Visit.php on line 583
sgiehl pushed a commit that referenced this pull request Feb 3, 2025
* Avoid strlen(null) call on undefined "idvisitor" property

The "idvisitor" property can be undefined/null, this must be taken into account to avoid this error:

> strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /.../core/Tracker/Visit.php on line 583

* Use consistent check for undefined "idvisitor" property

This is more in line with other locations in this class.

Co-authored-by: Michal Kleiner <mk@011.nz>

---------

Co-authored-by: Michal Kleiner <mk@011.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants