Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for pinned tabs in Safari #10385

Merged
merged 2 commits into from Aug 29, 2016

Conversation

Projects
None yet
3 participants
@vekunz
Copy link
Contributor

commented Aug 8, 2016

The browser Safari supports pinned tabs since version 9, but you need a special icon for this tab. Otherwise only a default icon is shown, and not the favicon.

@vekunz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2016

I don't know, why some of the test failed. But some of them doesn't failed because of my changes. For example the tests with the screenshots could not fail, because I changed nothing on the UI.

"http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">
<svg xmlns="http://www.w3.org/2000/svg" version="1.0" viewBox="0 0 16 16">

<g transform="translate(0 500) scale(0.1 -0.1)" fill="#000000" stroke="none">

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 9, 2016

Member

The color should be ideally #d4291f

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 9, 2016

I'm pretty sure the failing tests are not related to your change. I commented on the color and will try to test it in the next days

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 9, 2016

Thanks for creating the PR! 👍

@@ -1,4 +1,4 @@
{% if isCustomLogo and customFavicon is defined and customFavicon %}
{% else %}
<link rel="mask-icon" href="plugins/CoreHome/images/applePinnedTab.svg" color="#C81319">
<link rel="mask-icon" href="plugins/CoreHome/images/applePinnedTab.svg" color="#d4291f">

This comment has been minimized.

Copy link
@vekunz

vekunz Aug 9, 2016

Author Contributor

The svg image must be completely black. The color is written into in the HTML-Head. Here some more information about the Tab Icon: Apple Developer Library

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 9, 2016

Member

👍 thx for the link

@vekunz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2016

I changed the color.

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 15, 2016

I have not forgotten you. I will merge in a couple of days as I first need to merge another big PR to avoid merge issues.

@mattab mattab added this to the 3.0.0-b1 milestone Aug 23, 2016

@mattab mattab added the Enhancement label Aug 23, 2016

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

Thanks @vekunz Just tested it in Safari and works great!

@tsteur tsteur merged commit 14100e5 into matomo-org:3.x-dev Aug 29, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@vekunz vekunz deleted the vekunz:pinnedTabIcon branch Aug 29, 2016

@Findus23 Findus23 referenced this pull request May 22, 2017

Closed

Add safari tab icon #11726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.