Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated events #10455

Merged
merged 11 commits into from Sep 1, 2016

Conversation

Projects
None yet
1 participant
@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

fixes #8503
replaces #8620

The 2 failing UI tests are rather random build errors: http://builds-artifacts.piwik.org/piwik/piwik/8503/14940/ We might have to update those screenshots after merging.

It was not as easy as simply removing all events as some were still in use. I already adjusted treemap plugin to be compatible with 2.X and 3.X

@tsteur tsteur added the Needs Review label Aug 30, 2016

@tsteur tsteur added this to the 3.0.0-b1 milestone Aug 30, 2016

@tsteur tsteur referenced this pull request Aug 30, 2016

Closed

Remove deprecated events #8620

@@ -66,6 +84,7 @@ Read more about migrating a plugin from Piwik 2.X to Piwik 3 on our [Migration g
* The JavaScript AjaxHelper has a new method `ajaxHelper.withTokenInUrl()` to easily send a token along a XHR. Within the Controller the existence of this token can be checked via `$this->checkTokenInUrl();` to prevent CSRF attacks.
* The new class `Piwik\Updater\Migration\Factory` lets you easily create migrations that can be executed during an update. For example database or plugin related migrations. To generate a new update with migrations execute `./console generate:update`.
* The new method `Piwik\Updater::executeMigration` lets you execute a single migration.
* New event `ViewDataTable.filterViewDataTable` let's you filter available visualizations

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 30, 2016

Author Member

I removed the old ViewDataTable.addViewDataTable and replaced it with ViewDataTable.filterViewDataTable. In general we always want to add components via the PHP files and to filter things we always use events. The ViewDataTable.filterViewDataTable is used and needed by Treemap plugin but will be also useful for other plugins

@@ -171,40 +174,35 @@ public function getId()
*/
public static function getAllDimensions()
{
$dimensions = array();
$cacheId = CacheId::pluginAware('AllDimensions');

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 30, 2016

Author Member

We did not return dimensions that only extend the base Dimension class such as done by CustomVariables dimension. It now actually returns all dimensions

@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Aug 31, 2016

When merging we also need to create a PR and merge matomo-org/plugin-CustomDimensions@3.x-dev...8503 . It was not trivial to remove all deprecated events but most are removed. The failing screenshot tests are not related to this PR

@tsteur tsteur force-pushed the 3.x-dev branch from 954175e to 5d52b77 Sep 1, 2016

@tsteur tsteur force-pushed the 8503_2 branch from 66a7373 to 085f169 Sep 1, 2016

@tsteur tsteur merged commit 9efc734 into 3.x-dev Sep 1, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tsteur tsteur deleted the 8503_2 branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.