Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed plugin ExampleRssWidget -> RssWidget #10528

Merged
merged 3 commits into from Sep 22, 2016

Conversation

Projects
None yet
2 participants
@mattab
Copy link
Member

mattab commented Sep 20, 2016

  • Should be fully backward compatible
  • Need to check that tests still pass
  • Fixes #9791

@mattab mattab added the Needs Review label Sep 20, 2016

@mattab mattab added this to the 3.0.0-b1 milestone Sep 20, 2016

@mattab mattab merged commit d7bb13c into 3.x-dev Sep 22, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mattab mattab deleted the renamed_plugin branch Sep 22, 2016

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Sep 23, 2016

Do we need an update for existing dashboards?
Do we need to deactivate the old plugin so it will be removed from the list?

mattab added a commit that referenced this pull request Sep 23, 2016

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Sep 23, 2016

Do we need an update for existing dashboards?

No because the old module will be redirected/proxied to the new one.

Do we need to deactivate the old plugin so it will be removed from the list?

didn't check if that's necessary, but added it for safety in: 432c73e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.