Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On very high traffic Piwik servers, prevent integer overflow by making auto_increment fields BIGINT UNSIGNED #10548

Merged
merged 13 commits into from Sep 26, 2016

Conversation

Projects
None yet
1 participant
@mattab
Copy link
Member

mattab commented Sep 23, 2016

  • New system test that forces an integer overflow, initially failing as expected
  • Make all overflow-able fields BIGINT UNSIGNED in the schema
  • Add the Update script to manually modify all the fields (which aren't yet Dimension columns) from INT to BIGINT
  • Install a clean Piwik 3.0.0-b1 - manually compare the schema to an upgraded 2.16.0 -> 3.0.0-b1 and confirm the schema is same

Fixes #3288

@mattab mattab added this to the 3.0.0-b1 milestone Sep 23, 2016

@mattab mattab self-assigned this Sep 23, 2016

mattab added some commits Sep 23, 2016

@mattab mattab merged commit cdc50dc into 3.x-dev Sep 26, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@mattab mattab deleted the bigint branch Sep 26, 2016

idaction_name_ref INTEGER(10) UNSIGNED NULL,
idvisit BIGINT(10) UNSIGNED NOT NULL,
idaction_url_ref BIGINT(10) UNSIGNED NULL DEFAULT 0,
idaction_name_ref BIGINT(10) UNSIGNED NULL,

This comment has been minimized.

Copy link
@mattab

mattab Sep 26, 2016

Author Member

Note: starting in Piwik 3 each pageview now has 16 bytes overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.