Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JSON property for Piwik custom trackers #11025

Merged
merged 2 commits into from Dec 16, 2016

Conversation

Projects
None yet
2 participants
@tsteur
Copy link
Member

commented Dec 16, 2016

It would be good to expose the JSON Piwik uses in the Piwik object. This allows plugins to use Piwik.JSON so they don't have to use hard coded eg JSON2.

This would be great to have in Piwik 3 final release as it makes sure tracker plugins will have a working JSON even when Piwik changes it's JSON usage eg in #11024 to JSON_PIWIK.

It can't break anything so it should be an easy merge

tsteur added some commits Dec 15, 2016

@tsteur tsteur added the Needs Review label Dec 16, 2016

@tsteur tsteur added this to the 3.0.0-rc milestone Dec 16, 2016

@mattab

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

FYI tests fail in https://travis-ci.org/piwik/piwik/jobs/184434598
Would be great to merge this one!

@tsteur

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2016

was already fixed when I added tests

@mattab mattab merged commit 8895d90 into 3.x-dev Dec 16, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@mattab mattab deleted the jsonpwiwik2 branch Dec 16, 2016

@mattab mattab assigned mattab and unassigned mattab Dec 18, 2016

@mattab mattab added the Enhancement label Dec 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.