Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik.js: Added new method "getLinkTrackingTimer" #11317

Merged
merged 2 commits into from Feb 3, 2017

Conversation

Projects
None yet
1 participant
@tsteur
Copy link
Member

tsteur commented Feb 3, 2017

Also fixed an issue in dataTable to prevent an angular error when scope is not defined

tsteur added some commits Feb 3, 2017

@@ -293,7 +293,10 @@ $.extend(DataTable.prototype, UIControl.prototype, {

content.trigger('piwik:dataTableLoaded');

piwikHelper.lazyScrollTo(content[0], 400);
if (doScroll || 'undefined' === typeof doScroll) {

This comment has been minimized.

Copy link
@tsteur

tsteur Feb 3, 2017

Author Member

this was needed to prevent scrolling in a plugin

@@ -119,7 +119,9 @@ var piwikHelper = {

angular.element(document).injector().invoke(function($compile) {
var scope = angular.element($element).scope();
$compile($element)(scope);
if (scope) {
$compile($element)(scope);

This comment has been minimized.

Copy link
@tsteur

tsteur Feb 3, 2017

Author Member

fixes possible angular error when data table reloads

@tsteur tsteur merged commit 437e371 into 3.x-dev Feb 3, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@tsteur tsteur deleted the trackerfixes branch Feb 3, 2017

@mattab mattab changed the title Added new method "getLinkTrackingTimer" piwik.js: Added new method "getLinkTrackingTimer" Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.