Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix multiple memory leaks in UserCountryMap #11350
See commits for details. The Raphael upgrade fixes the most serious memory leak.
You can verify the problem(s) by following these steps.
Prerequisites: The map is visible on the dashboard (i.e., piwik has collected data recently)
In addition, every time you click on the "Dashboard" link in the left menu, Piwik appends a
pushed a commit
this pull request
Feb 19, 2017
Note that there is still a tiny small memory leak caused by Raphael's behavior. I've submitted a PR to Raphael that eliminates this tiny memory leak.
Regardless, this PR alone turns the large memory leak into a tiny memory leak, so it is worth considering / merging before Raphael considers/merges the other fix.
@jvilk thanks for that PR. Seems to fix the memory leak in this case.
I'm gonna merge this now.
While testing I maybe found another memory leak. When clicking the reload button for the usercountry widget the required memory still increases a lot, guess the widget is not destroyed before it's reloaded or something similar. Would you maybe be keen to have a look at that, too?