Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system check for the hash() function #11455

Merged
merged 2 commits into from Mar 17, 2017

Conversation

@okay19
Copy link
Contributor

commented Mar 4, 2017

Check during install if the hash() function exists in PHP. While enabled by default, it is possible to exclude this function at compile time by passing --disable-hash to configure. Fixes #11449.

@okay19

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2017

Looks like the CI failed because of the screenshot test. Should I change anything in the PR to reflect that?

@sgiehl

This comment has been minimized.

Copy link
Member

commented Mar 6, 2017

You can update the expected UI test files by using the processed one from travis: http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/22539/processed/Installation_system_check.png
That should fix the tests.

@sgiehl

This comment has been minimized.

Copy link
Member

commented Mar 16, 2017

@okay19 seems the screenshot is now no longer stored on GitLFS. Are you able to change that? If not maybe remove the commit again and I will update that afterwards

@okay19

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2017

@sgiehl Done. I haven't used Git LFS before, so I had to do a little research.

@sgiehl

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

awesome. Thanks for the update. Now all tests are passing 👍

@sgiehl sgiehl merged commit c488e33 into matomo-org:3.x-dev Mar 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sgiehl sgiehl added this to the 3.0.3 milestone Mar 17, 2017

@mattab

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

Thanks @okay19 for your contributions recently! Would be awesome if you want to contribute more 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.