New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post JavaScript events when performing an action #11463

Merged
merged 3 commits into from Mar 18, 2017

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Mar 7, 2017

So plugins can listen to it. They don't need documentation since they won't be official API

tsteur added some commits Mar 7, 2017

@tsteur tsteur added the Needs Review label Mar 7, 2017

@tsteur tsteur added this to the 3.0.3 milestone Mar 7, 2017

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 15, 2017

FYI we will also need to merge matomo-org/plugin-CustomDimensions#58

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 17, 2017

LGTM, the one in the plugin as well. Shall we add that in CustomAlerts, as well? Just to be consistent...

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 18, 2017

Good point, will add it there

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 18, 2017

FYI: Tried to add it to custom alerts but wasn't as trivial because it is a plain link there and not angularjs. Will add it when we need it

@tsteur tsteur merged commit 173294b into 3.x-dev Mar 18, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@tsteur tsteur deleted the jsevents branch Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment