New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post current action in Template.beforeContent event #11481

Merged
merged 2 commits into from Mar 18, 2017

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Mar 14, 2017

Be good to have this as well when wanting to restrict content to certain actions. Didn't add it to changelog since those events are not official APIs AFAIK

Post current action in Template.beforeContent event
Be good to have this as well when wanting to restrict content to certain actions

@tsteur tsteur added the Needs Review label Mar 14, 2017

@tsteur tsteur added this to the 3.0.3 milestone Mar 14, 2017

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 17, 2017

LGTM. According to the issue, those events were added to make themeing easier. Not sure if they should be official API or not. But afaik they aren't mentioned anywhere in the docs.

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 18, 2017

Yep they aren't mentioned and not even used. We could alternatively even remove them as I don't need them myself anymore. Merging for now and I presume it doesn't hurt for now to have them but also happy to remove them

@tsteur tsteur merged commit 77fb7f7 into 3.x-dev Mar 18, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tsteur tsteur deleted the currentactioninevent branch Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment