New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to ignore ssl errors when running U tests via PhantomJS #11482

Merged
merged 2 commits into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Mar 14, 2017

If nobody has a problem with it, can also add this option by default as there should be no problem with it.

Add new option to ignore ssl errors when running U tests via PhantomJS
If nobody has a problem with it, can also add this option by default as there should be no problem with it.

@tsteur tsteur added the Needs Review label Mar 14, 2017

@tsteur tsteur added this to the 3.0.3 milestone Mar 14, 2017

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 16, 2017

LGTM. Guess adding that by default shouldn't cause any problems.

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 17, 2017

Sweet, thank you. Enabled it by default then. If there are any problems we can add the option.

@tsteur tsteur merged commit 1874dd0 into 3.x-dev Mar 17, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@tsteur tsteur deleted the phantomjs_ui_tests_ignoressl branch Mar 17, 2017

@mattab mattab added the c: Tests & QA label Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment