New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to select a specific frame within a page #11484

Merged
merged 4 commits into from Mar 20, 2017

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Mar 14, 2017

eg page.selectFrame('myFrameName'); and at the end of the test page.selectMainFrame();

What doesn't seem to work yet correctly is typing within the frame. I presume the position where the click should happen is not calculated correctly (it clicks before sending keys).

Add possibility to select a specific frame within a page
eg `page.selectFrame('myFrameName');` and at the end of the test `page.selectMainFrame();`

What doesn't seem to work yet correctly is typing within the frame. I presume the position where the click should happen is not calculated correctly (it clicks before sending keys).

@tsteur tsteur added the Needs Review label Mar 14, 2017

@tsteur tsteur added this to the 3.0.3 milestone Mar 14, 2017

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 15, 2017

Now also supports page.click(selector)

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 15, 2017

Still a little issue is when selecting a frame within a frame, but planning on fixing this right now unless needed.

@tsteur

This comment has been minimized.

Member

tsteur commented Mar 20, 2017

Merging now as needed in 3.x-dev branch. Tests still succeed and do not affect any of our existing tests.

@tsteur tsteur merged commit 92257e4 into 3.x-dev Mar 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsteur tsteur deleted the uitests_frames branch Mar 20, 2017

@mattab

This comment has been minimized.

Member

mattab commented Mar 21, 2017

If possible would be nice to document this new feature in https://developer.piwik.org/guides/tests-ui#capturing-only-a-part-of-the-page even very quick 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment