New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Overlay: for links to the left of the screen, bubbles are partially hidden #11511

Merged
merged 3 commits into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@phoob
Contributor

phoob commented Mar 22, 2017

Fix for #11509

@phoob

This comment has been minimized.

Contributor

phoob commented Mar 22, 2017

--> needs cross browser testing, but seems to work ok in chrome and firefox on mac..

@mattab mattab added this to the 3.0.3 milestone Mar 22, 2017

@mattab mattab added the Needs Review label Mar 22, 2017

phoob added some commits Mar 22, 2017

Update followingpages.js
better css, allow for smooth transition and more control.
Update client.css
add transition css.
@phoob

I made a few more tweaks to the css, using translate instead of top/left css. This makes it more smooth to animate (via transition), and there is only one mechanism for altering the position (translate).

@mattab

This comment has been minimized.

Member

mattab commented Mar 22, 2017

Cheers @phoob this looks really nice now! well done 👍

Maybe you can help us with the next issue that appeared: #11510

@mattab mattab merged commit 443d1fb into matomo-org:3.x-dev Mar 22, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mattab mattab changed the title from Update followingpages.js to Page Overlay: for links to the left of the screen, bubbles are partially hidden Mar 22, 2017

@mattab mattab added the Bug label Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment