Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable Flatten feature for a given report #11529

Merged
merged 4 commits into from Mar 29, 2017

Conversation

@sgiehl
Copy link
Member

commented Mar 26, 2017

Currently datatables are automatically flattened if the flat parameter is given in the request. This cannot be prevented.
It is now possible to set for a report if it supports flattening or not. This will also automatically be set to the view, so it's not required to set if for report and view as well.

This PR also disables the flattening for the referrer type report, as it doesn't work for that report.

fixes #11323

@sgiehl sgiehl added this to the 3.0.3 milestone Mar 26, 2017

@sgiehl sgiehl force-pushed the flattenfilter branch from 4b3034e to 8a32567 Mar 26, 2017

@sgiehl sgiehl changed the title Make it possible to disable flattening for an datatable Make it possible to disable flattening for an report Mar 26, 2017

@sgiehl sgiehl force-pushed the flattenfilter branch from 8a32567 to 518e0bd Mar 26, 2017

@mattab
Copy link
Member

left a comment

Looks good. Left a couple naming comments

@@ -8,6 +8,7 @@ The Product Changelog at **[piwik.org/changelog](http://piwik.org/changelog)** l

### Breaking Changes
* New config setting `enable_plugin_upload` lets you enable uploading and installing a Piwik plugin ZIP file by a Super User. This used to be enabled by default, but it is now disabled by default now for security reasons.
* New property `Report::$supportsFlattening` lets you define if a report supports flattening (d)efaults to `true`). If set to `false` it will also set `ViewDataTable\Config::$show_flatten_table` to `false`

This comment has been minimized.

Copy link
@mattab

mattab Mar 27, 2017

Member

Indicate what "property" refers to. something like New Report class property or so

* @var bool
* @api
*/
protected $supportsFlattening = true;

This comment has been minimized.

Copy link
@mattab

mattab Mar 27, 2017

Member

rename to supportsFlatten

* @return bool
* @ignore
*/
public function supportsFlattening()

This comment has been minimized.

Copy link
@mattab

mattab Mar 27, 2017

Member

rename to supportsFlatten

@sgiehl sgiehl force-pushed the flattenfilter branch from fe0f444 to d833a63 Mar 29, 2017

@mattab mattab merged commit 5d46f80 into 3.x-dev Mar 29, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@mattab

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

👍

@mattab mattab deleted the flattenfilter branch Mar 29, 2017

@mattab mattab changed the title Make it possible to disable flattening for an report Make it possible to disable Flatten feature for a given report Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.