Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Changes to support custom periods #11837
This PR contains the following changes which allow defining & handling custom period types.
Looking at the unit test failures, I'm not sure if it's a good idea to make
I think ideally, the build function shouldn't be called as much as it is. Since it only creates a period instance from query parameters, I think it should ideally only be called at the beginning of a request. This would be a very large change to make, though.
I see three options to solve this (please suggest others if I'm missing something):