GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brings the formatting of the real time widget inline with the rest of the number formatting.
Addresses issue: #11967
Formats numbers in the real time widget
Thanks for the pull request @AMcNeice and welcome to our project 👍
we'll review this in the coming days/weeks!
Haven't tested your changes yet, but isn't the formatting done twice this way.
The number filter for twig uses this method, which calls NumberFormatter::format, but that is already done in Controller. So guess it should be enough to do it either in Controller or in View.
@sgiehl - Makes sense, missed the twig formatting referencing that function. I'll test locally and push up some changes that only has the formatting in the view so that all of the items are calling the same helper function.
Defers real-time widget formatting to the view only
Thanks for the PR @AMcNeice 👍