New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show bundles in premium feature widgets #12179

Merged
merged 2 commits into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Oct 12, 2017

In "Latest Marketplace Updates" and "Premium Features" widgets which are on the admin home page, do not show bundles as it seems less confusing etc and I think it is not needed to show them there. Better to show individual features.

@tsteur tsteur added the Needs Review label Oct 12, 2017

@tsteur tsteur added this to the 3.2.1 milestone Oct 12, 2017

@mneudert

mneudert approved these changes Oct 13, 2017 edited

LGTM.

Btw the empty($plugins) check in GetPremiumFeatures.php could also be removed. It probably was not needed for a long time as searchForPlugins should always return an array.

(Tests should of course still work before merging. The current failures however seem unrelated to this specific change)

@mattab mattab merged commit 016f0b2 into 3.x-dev Oct 19, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mattab mattab deleted the bundleupdate branch Oct 19, 2017

@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment