New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility for themes to change text color in header #12204

Merged
merged 3 commits into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Oct 18, 2017

fixes #12201 If I understand it correctly, the color in the header should be changeable which I totally agree to in order to make it useful.

Expecting UI tests to fail for the theming part with black menu text color.

For the variable I used the ending -text even though they are technically links (-link) to be consistent with the menu.

@tsteur tsteur added this to the 3.2.1 milestone Oct 18, 2017

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Oct 18, 2017

Member

UI test failures are not from this PR

Member

tsteur commented Oct 18, 2017

UI test failures are not from this PR

@sgiehl

Left a comment. Besides that, looks good

Show outdated Hide outdated CHANGELOG.md
@sgiehl

sgiehl approved these changes Oct 25, 2017

Fixed the typo. Now LGTM

@mattab mattab merged commit 80214a8 into 3.x-dev Nov 19, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mattab mattab deleted the 12201 branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment