New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visitor details events #12262

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Nov 9, 2017

Similar to Report.add/filterReports, Widget.add/filterWidgets, etc

We can change naming but kept it consistent with these existing events. It may be a bit confusing to have Live.addVisitorDetails and Live.filterVisitorDetails vs Live.getAllVisitorDetails. For Live.getAllVisitorDetails you would then expect it returns maybe all visitor detail instances. The first 2 work basically on the raw instances, whereas Live.getAllVisitorDetails works on the actual visitor details data. Any thoughts @sgiehl ?

Add visitor details events
Similar to Report.add/filterReports, Widget.add/filterWidgets, etc

We can change naming but kept it consistent with these existing events. It may be a bit confusing to have `Live.addVisitorDetails` and `Live.filterVisitorDetails` vs `Live.getAllVisitorDetails`. For `Live.getAllVisitorDetails` you would then expect it returns maybe all visitor detail instances. The first 2 work basically on the raw instances, whereas `Live.getAllVisitorDetails` works on the actual visitor details data. Any thoughts @sgiehl ?

@tsteur tsteur added this to the 3.2.1 milestone Nov 9, 2017

@sgiehl

sgiehl approved these changes Nov 9, 2017

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Nov 9, 2017

Member

The event Live.getAllVisitorDetails is deprecated. So guess the naming is fine.

Member

sgiehl commented on 8932325 Nov 9, 2017

The event Live.getAllVisitorDetails is deprecated. So guess the naming is fine.

@tsteur tsteur merged commit a0545ed into 3.x-dev Nov 9, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tsteur tsteur deleted the visitordetailsevents branch Nov 9, 2017

@matomo-org matomo-org deleted a comment from MatomoForumBot Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment