New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #12269

Closed
wants to merge 1 commit into
base: 3.x-dev
from

Conversation

Projects
None yet
3 participants
@carusogabriel

carusogabriel commented Nov 11, 2017

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just to bumped PHPUnit version to 4.8.35, that support this namespace.

@sgiehl sgiehl added this to the 3.3.0 milestone Nov 12, 2017

@sgiehl

sgiehl approved these changes Nov 13, 2017

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Nov 13, 2017

Member

Should be ready to merge. But we also need to update all the tests in our plugin repos...

Member

sgiehl commented Nov 13, 2017

Should be ready to merge. But we also need to update all the tests in our plugin repos...

@carusogabriel

This comment has been minimized.

Show comment
Hide comment
@carusogabriel

carusogabriel Nov 13, 2017

@sgiehl I'm going to work on them!

carusogabriel commented Nov 13, 2017

@sgiehl I'm going to work on them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment