New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide widgets not working without internet connection if disabled in config #12279

Merged
merged 5 commits into from Mar 22, 2018

Conversation

Projects
None yet
3 participants
@sgiehl
Member

sgiehl commented Nov 15, 2017

Hide widgets when enable_internet_features = 0 is set in config:

  • SEO > SEO rankings
  • About Piwik > Piwik Changelog
  • About Piwik > Piwik.org Blog
  • About Piwik > Latest Marketplace Updates
  • About Piwik > Premium Features

refs #6324

@mattab mattab added this to the 3.2.2 milestone Nov 22, 2017

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Dec 15, 2017

Member

We'd also need to hide the

  • Premium features widget
  • Latest Marketplace Updates widget
  • let's also test most screens in Admin, without internet, to check the feature really works, there are maybe a few remaining things to disable
Member

mattab commented Dec 15, 2017

We'd also need to hide the

  • Premium features widget
  • Latest Marketplace Updates widget
  • let's also test most screens in Admin, without internet, to check the feature really works, there are maybe a few remaining things to disable
@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Dec 15, 2017

Member

@mattab The two mentioned widgets are now removed as well. Everything else shouldn't be handled in this PR. It's only one step towards solving #6324. It's better to keep pull requests simple and small, so they can be easily merged. So maybe add your other comment in that issue.

Member

sgiehl commented Dec 15, 2017

@mattab The two mentioned widgets are now removed as well. Everything else shouldn't be handled in this PR. It's only one step towards solving #6324. It's better to keep pull requests simple and small, so they can be easily merged. So maybe add your other comment in that issue.

@mattab mattab modified the milestones: 3.4.0, 3.3.1 Mar 19, 2018

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 20, 2018

Member

Would it be possible to use consts for the widget categories/names? If the names change, these new changes might break.

Member

diosmosis commented Mar 20, 2018

Would it be possible to use consts for the widget categories/names? If the names change, these new changes might break.

@mattab mattab modified the milestones: 3.4.0, 3.4.1 Mar 22, 2018

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Mar 22, 2018

Member

I've updated the PR so it better handles possible name changes of the widgets

Member

sgiehl commented Mar 22, 2018

I've updated the PR so it better handles possible name changes of the widgets

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 22, 2018

Member

@mattab PR looks good, the UI test failures seem unrelated.

Member

diosmosis commented Mar 22, 2018

@mattab PR looks good, the UI test failures seem unrelated.

@mattab mattab merged commit c61018b into 3.x-dev Mar 22, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@mattab mattab deleted the seowidgetnointernet branch Mar 22, 2018

@mattab mattab modified the milestones: 3.4.1, 3.4.0 Mar 22, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Hide widgets not working without internet connection if disabled in c…
…onfig (matomo-org#12279)

* Hide SEO rankings widget if internet is disabled in config

* Hide RSS widgets if internet is disabled in config

* Remove more wirdgets when internet connection disabled

* Adjust widgets to remove after rename to Matomo

* Code improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment