New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added events for adding and filtering profile summaries #12303

Merged
merged 2 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Nov 27, 2017

@sgiehl adding events similar to visitor details events. Will be needed in next release if possible.

tsteur added some commits Nov 27, 2017

@tsteur tsteur added the Needs Review label Nov 27, 2017

@tsteur tsteur added this to the 3.2.1 milestone Nov 27, 2017

@tsteur tsteur requested a review from sgiehl Nov 27, 2017

*
* @param ProfileSummaryAbstract[] $profileSummaries An array of profile summaries
*/
Piwik::postEvent('Live.addProfileSummaries', array(&$instances));

This comment has been minimized.

@sgiehl

sgiehl Nov 27, 2017

Member

Not sure if we should introduce an event for adding summaries, as this is done automatically by looking for classes extending the ProfileSummary class.

@sgiehl

sgiehl Nov 27, 2017

Member

Not sure if we should introduce an event for adding summaries, as this is done automatically by looking for classes extending the ProfileSummary class.

This comment has been minimized.

@tsteur

tsteur Nov 27, 2017

Member

It is basically the same as for Visitor Details, Widgets, Reports, ... this way, it allows plugins that define entities, such as custom dimensions, to add for example a profile summary for each entity / custom dimension. It is just a general thing that we do so far as not always it is possible to have it in the plugin structure.

@tsteur

tsteur Nov 27, 2017

Member

It is basically the same as for Visitor Details, Widgets, Reports, ... this way, it allows plugins that define entities, such as custom dimensions, to add for example a profile summary for each entity / custom dimension. It is just a general thing that we do so far as not always it is possible to have it in the plugin structure.

This comment has been minimized.

@sgiehl

sgiehl Nov 27, 2017

Member

ah sure. Guess I haven't thought enough before writing the comment...

@sgiehl

sgiehl Nov 27, 2017

Member

ah sure. Guess I haven't thought enough before writing the comment...

@sgiehl

sgiehl approved these changes Nov 27, 2017

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Nov 27, 2017

Member

UI test failures seem to be random failures by the looks or not related to this PR: eg https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/25168/UIIntegrationTest_dashboard2.png

Member

tsteur commented Nov 27, 2017

UI test failures seem to be random failures by the looks or not related to this PR: eg https://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/25168/UIIntegrationTest_dashboard2.png

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Nov 27, 2017

Member

Those failures are related to #12220 I guess

Member

sgiehl commented Nov 27, 2017

Those failures are related to #12220 I guess

@tsteur tsteur merged commit 1ff4c85 into 3.x-dev Nov 27, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@tsteur tsteur deleted the profilesummaryevents branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment