New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates the `historyService` along with `broadcast.init`, `broadcast.propagateAjax`, `broadcast.pageLoad` #12363

Merged
merged 5 commits into from Jun 17, 2018

Conversation

Projects
None yet
3 participants
@sgiehl
Member

sgiehl commented Dec 16, 2017

those methods have been used by overlay and in widgetized dashboard only and should now not be used anywhere

refs #6037

@sgiehl sgiehl added this to the 3.2.2 milestone Dec 16, 2017

// init broadcast if not already done (it is required to make popovers work in widgetize mode)
if (broadcast.isWidgetizedDashboard()) {
broadcast.init(true);
}

This comment has been minimized.

@sgiehl

sgiehl Dec 16, 2017

Member

adding <div piwik-popover-handler></div> in the widgetized dashboard template makes this no longer required

@sgiehl

sgiehl Dec 16, 2017

Member

adding <div piwik-popover-handler></div> in the widgetized dashboard template makes this no longer required

@diosmosis

Tested overlay locally + popovers in widgetized dashboard, appears to work as before.

@diosmosis diosmosis merged commit eb18603 into 3.x-dev Jun 17, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the broadcast branch Jun 17, 2018

@mattab mattab added the c: Platform label Aug 28, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Deprecates the `historyService` along with `broadcast.init`, `broadca…
…st.propagateAjax`, `broadcast.pageLoad` (matomo-org#12363)

* deprecates broadcast.propagateAjax()

* make overlay js independed from history service and some broadcast methods

* deprecates historyService alogn with some broadcast methods

* make popovers work in widgetized dashboard without history service

* do not update overlay page/sidebar when iframe url didn't change

prevents reloading data when opening a popover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment