New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current date and period for overlay links #12364

Closed
wants to merge 1 commit into
base: 3.x-dev
from

Conversation

Projects
None yet
2 participants
@sgiehl
Member

sgiehl commented Dec 16, 2017

Overlays currently open showing data for the current month. Not sure if that would be the expected behavior, but imho it should show the current selected date and period instead.

@sgiehl sgiehl added the Needs Review label Dec 16, 2017

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Jan 10, 2018

Member

The current behavior is on purpose, for cases such as:

  • looking at old data, like 6 months old, would likely show a wrong overlay (the design may have changed, content changes, etc.). -> Overlay is focused on "Fresh data" since it's so tied to the website design.
  • looking at large datasets, where overlay data may be slow to fetch. -> By showing Current month we minimise risk of loading too much data and the report failing

Hope this clarifies

Member

mattab commented Jan 10, 2018

The current behavior is on purpose, for cases such as:

  • looking at old data, like 6 months old, would likely show a wrong overlay (the design may have changed, content changes, etc.). -> Overlay is focused on "Fresh data" since it's so tied to the website design.
  • looking at large datasets, where overlay data may be slow to fetch. -> By showing Current month we minimise risk of loading too much data and the report failing

Hope this clarifies

@mattab mattab closed this Jan 10, 2018

@sgiehl sgiehl deleted the overlaylink branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment