New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show information in visitor profile if dataset was "truncated" #12376

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@sgiehl
Member

sgiehl commented Dec 20, 2017

Shown visits in visitor profile is currently limited by live_visitor_profile_max_visits_to_aggregate (default 100). As some users might exceed this limit it would be helpful to show at least a message that the summary only represents the last X visits.

based on #12375

refs #12373

@sgiehl sgiehl added the Needs Review label Dec 20, 2017

@sgiehl sgiehl added this to the 3.2.2 milestone Dec 20, 2017

@mattab mattab modified the milestones: 3.4.0, 3.3.1 Mar 19, 2018

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 20, 2018

Member

System test is failing (makeVisitorTableFromArray() call added in previous PR is missing the new $rowCount parameter). Otherwise looks good.

Member

diosmosis commented Mar 20, 2018

System test is failing (makeVisitorTableFromArray() call added in previous PR is missing the new $rowCount parameter). Otherwise looks good.

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 23, 2018

Member

Not sure why, but FOUND_ROWS() isn't working on travis or for me locally. Still investigating...

Member

diosmosis commented Mar 23, 2018

Not sure why, but FOUND_ROWS() isn't working on travis or for me locally. Still investigating...

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 23, 2018

Member

found the issue, it's caused by the limit in the inner query: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/Model.php#L264-L268

FOUND_ROWS() will always be limited by that, I guess. @sgiehl is this something you noticed? or was it working for you?

Member

diosmosis commented Mar 23, 2018

found the issue, it's caused by the limit in the inner query: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/Model.php#L264-L268

FOUND_ROWS() will always be limited by that, I guess. @sgiehl is this something you noticed? or was it working for you?

@mattab mattab modified the milestones: 3.4.0, 3.4.1 Mar 23, 2018

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Mar 25, 2018

Member

Guess that worked in my tests, as the datasets were smaller than the $limit*10. But now only $limit is beeing used as iIrc a segment has been used before to load that data instead of directly using the $visitorId parameter. Need to have a closer look when I have some time if there is an easy solution for this...

Member

sgiehl commented Mar 25, 2018

Guess that worked in my tests, as the datasets were smaller than the $limit*10. But now only $limit is beeing used as iIrc a segment has been used before to load that data instead of directly using the $visitorId parameter. Need to have a closer look when I have some time if there is an easy solution for this...

@sgiehl sgiehl self-assigned this Mar 25, 2018

sgiehl added some commits Dec 20, 2017

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Apr 23, 2018

Member

LGTM 👍

Member

mattab commented Apr 23, 2018

LGTM 👍

@mattab mattab merged commit 14ba6a4 into 3.x-dev Apr 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mattab mattab deleted the visitorprofile branch Apr 23, 2018

mattab added a commit that referenced this pull request Apr 23, 2018

mattab added a commit that referenced this pull request Apr 23, 2018

Revert "Show information in visitor profile if dataset was "truncated…
…"" (#12761)

* Revert "Fix syntax vor 'SHOW COLUMNS FROM' (#12759)"

This reverts commit f69c1f6.

* Revert "fix #12722 (#12756)"

This reverts commit 6c3ed18.

* Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (#12742)"

This reverts commit fdb161b.

* Revert "Show information in visitor profile if dataset was "truncated" (#12376)"

This reverts commit 14ba6a4.

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Show information in visitor profile if dataset was "truncated" (matom…
…o-org#12376)

* Show overall visit count in visitor profile if there have been more visits than shown in the summary

* update/ add tests

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Revert "Show information in visitor profile if dataset was "truncated…
…"" (matomo-org#12761)

* Revert "Fix syntax vor 'SHOW COLUMNS FROM' (matomo-org#12759)"

This reverts commit f69c1f6.

* Revert "fix matomo-org#12722 (matomo-org#12756)"

This reverts commit 6c3ed18.

* Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (matomo-org#12742)"

This reverts commit fdb161b.

* Revert "Show information in visitor profile if dataset was "truncated" (matomo-org#12376)"

This reverts commit 14ba6a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment