New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message if visitor in visitor profile could not be found instead of fatal error #12396

Merged
merged 3 commits into from Jan 22, 2018

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Jan 3, 2018

Also added some permissions check. They are not 100% needed as the permissions are checked in the API calls anyway but makes sure they don't get random data from API response and shows always login screen instead of potentially a fatal error.

Show error message if visitor in visitor profile could not be found i…
…nstead of fatal error

Eg happens when visitorId URL parameter is missing.

@tsteur tsteur added the Bug label Jan 3, 2018

@tsteur tsteur added this to the 3.3.0 milestone Jan 3, 2018

Show outdated Hide outdated plugins/Live/Controller.php Outdated
@sgiehl

Should we maybe add UI test(s) for invalid profiles, to prove the behavior doesn't change again?

Show outdated Hide outdated plugins/Live/Controller.php Outdated
@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Jan 3, 2018

Member

It is not really for invalid profiles, but more for when the parameter is missing (although would also apply later to possibly deleted profiles once supported by Piwik). Test be useful, need to see when I get to it.

Member

tsteur commented Jan 3, 2018

It is not really for invalid profiles, but more for when the parameter is missing (although would also apply later to possibly deleted profiles once supported by Piwik). Test be useful, need to see when I get to it.

@mattab mattab merged commit 113099e into 3.x-dev Jan 22, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@mattab mattab deleted the visitorprofileemtty branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment