New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods away from Live controller #12406

Merged
merged 3 commits into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@sgiehl
Member

sgiehl commented Jan 6, 2018

fixes #12394

@sgiehl sgiehl added this to the 3.3.0 milestone Jan 6, 2018

@sgiehl sgiehl requested a review from tsteur Jan 7, 2018

Show outdated Hide outdated plugins/Live/Live.php Outdated
Show outdated Hide outdated plugins/Live/Live.php Outdated
@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Feb 26, 2018

Member

@tsteur would you have some time for another review on this? Would be good to merge some more of the open PRs

Member

sgiehl commented Feb 26, 2018

@tsteur would you have some time for another review on this? Would be good to merge some more of the open PRs

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Feb 26, 2018

Member

Just tested and worked. Be good to add the other comment, otherwise good to merge.

Member

tsteur commented Feb 26, 2018

Just tested and worked. Be good to add the other comment, otherwise good to merge.

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Feb 26, 2018

Member

Ok. I've added the comment. Will now wait for the tests before merging...

Member

sgiehl commented Feb 26, 2018

Ok. I've added the comment. Will now wait for the tests before merging...

@sgiehl sgiehl modified the milestones: 3.4.0, 3.3.1 Feb 26, 2018

@sgiehl sgiehl merged commit 9ff807e into 3.x-dev Feb 26, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@sgiehl sgiehl deleted the livecleanup branch Feb 26, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Move methods away from Live controller (matomo-org#12406)
* move methods away from Live controller

* Add new class ProfileSummaryProvider

* use transient cache instead of static variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment