Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating URLs, only strip PATH_INFO when it is not empty #12500

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@mattab
Copy link
Member

mattab commented Jan 23, 2018

If PATH_INFO is defined, but empty, this line otherwise causes the URL to be rewritten incorrectly
As reported in #6644 (comment)

If PATH_INFO  is defined, but empty, this line otherwise causes the URL to be rewritten incorrectly
As reported in #6644 (comment)
@PotcFdk

This comment has been minimized.

Copy link

PotcFdk commented Jan 24, 2018

LGTM

@@ -150,7 +150,7 @@ public static function getCurrentScriptName($removePathInfo = true)
}

// strip path_info
if ($removePathInfo && isset($_SERVER['PATH_INFO'])) {
if ($removePathInfo && !empty($_SERVER['PATH_INFO'])) {

This comment has been minimized.

Copy link
@tsteur

tsteur Jan 24, 2018

Member

makes sense

@mattab mattab merged commit dcd3b04 into 3.x-dev Jan 24, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@mattab mattab deleted the url_path_info branch Jan 24, 2018
@mattab mattab changed the title Only strip PATH_INFO when it is set to a value When generating URLs, only strip PATH_INFO when it is not empty Mar 27, 2018
@mattab mattab added the Bug label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.