New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show flattened columns as extra columns in UI #12524

Open
wants to merge 4 commits into
base: 3.x-dev
from

Conversation

Projects
None yet
4 participants
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2018

No description provided.

@sgiehl sgiehl force-pushed the flattenviz branch from c34004a to bae9e0a Jan 31, 2018

@mattab mattab added this to the 3.4.0 milestone Feb 1, 2018

@sgiehl sgiehl force-pushed the flattenviz branch 2 times, most recently from 4ebedc4 to 5fce3c9 Feb 3, 2018

@sgiehl sgiehl force-pushed the flattenviz branch 2 times, most recently from c9c0145 to 5fa0410 Mar 11, 2018

@sgiehl sgiehl force-pushed the flattenviz branch 2 times, most recently from 1af6629 to 7c4e352 Mar 30, 2018

@diosmosis diosmosis modified the milestones: 3.6.0, 3.7.0 Jul 24, 2018

@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018

@mattab mattab modified the milestones: 3.6.1, 3.7.0 Oct 8, 2018

@sgiehl sgiehl force-pushed the flattenviz branch from 7c4e352 to 1e88ef0 Dec 17, 2018

@sgiehl sgiehl force-pushed the flattenviz branch from 0dc8f1e to cd90367 Dec 17, 2018

@mattab mattab modified the milestones: 3.8.0, 3.9.0 Dec 31, 2018

@mattab mattab requested review from tsteur , mattab and diosmosis Dec 31, 2018

@@ -533,6 +534,16 @@ public function __construct()
foreach ($this->selectable_periods as $period) {
$this->translations[$period] = ucfirst(Piwik::translate('Intl_Period' . ucfirst($period)));
}
foreach (Dimension::getAllDimensions() as $dimension) {

This comment has been minimized.

@tsteur

tsteur Jan 2, 2019

Member

Any chance we maybe only add them in the HtmlTable config? Other visualisations shouldn't need it? or even better only in the HtmlTable visualisation and only for the needed dimensions re performance?

@@ -106,6 +106,18 @@ private function flattenRow
(Row $row, $rowId, DataTable $dataTable, $level, $dimensionName,
$labelPrefix = '', $parentLogo = false)
{
$dimensions = $dataTable->getMetadata('dimensions');

This comment has been minimized.

@tsteur

tsteur Jan 2, 2019

Member

Any chance to do this maybe in the HtmlTable visualisation or so? Be nice to have this feature contained in one class or so and not spread across core, visualisations, etc.

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Jan 2, 2019

Can you add some tests for this? And ideally if possible also contain the code in one module or class. It looks otherwise bit fragile/hacked.

I've also tried to use it and saw eg
image

Not sure if it is normal to see a dash before others in Acquisition => Websites report? (maybe isn't related to this PR)

Also my understanding was we would not only always show it in two columns but maybe have an option or two different "flattening" features whether you want it grouped or not? Personally in most cases I wouldn't like this view and prefer it in one column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment