Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more font icons instead of images #12532

Merged
merged 4 commits into from Mar 20, 2018
Merged

Use more font icons instead of images #12532

merged 4 commits into from Mar 20, 2018

Conversation

@sgiehl
Copy link
Member

sgiehl commented Feb 3, 2018

I've added some more icons to the matomo font for:

  • row evolution
  • overlay
  • transitions

They look a bit different to the images we used before, but it's hard to find good vector graphics that matches the old ones. See the updated UI files...

The new icons are used in Overlay plugin and in all table reports as row action icons.

based on #12520

fixes #12465

@sgiehl sgiehl force-pushed the usemorefonticons branch 2 times, most recently from df6dffb to f15b9a3 Feb 4, 2018
@sgiehl sgiehl force-pushed the usemorefonticons branch 3 times, most recently from 5b15cbd to fcc1b16 Mar 11, 2018
@diosmosis

This comment has been minimized.

Copy link
Member

diosmosis commented Mar 20, 2018

LGTM

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Mar 20, 2018

Great choice of icons! 🎉

@sgiehl could you maybe resolve the conflicts and merge the PR directly?

@sgiehl sgiehl force-pushed the usemorefonticons branch from fcc1b16 to eadc459 Mar 20, 2018
@sgiehl sgiehl force-pushed the usemorefonticons branch from 60c6187 to e2515b4 Mar 20, 2018
@sgiehl sgiehl merged commit 2e3295b into 3.x-dev Mar 20, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@sgiehl sgiehl deleted the usemorefonticons branch Mar 20, 2018
InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Use more font icons instead of images

* update ui files

* fix test

* update UI files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.