Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed '-' when editing password in users manager #12698

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
3 participants
@emilekberg
Copy link
Contributor

commented Apr 5, 2018

Removed - when editing password, so it does not need to be manually removed
Removed editable class from username, that way no special if-statement is needed in manage-users.controller.js
I also fixed minor indentation issues.

I found this little dash (-) being present when changing fairly annoying, and the first 3 times i did not catch it. So i was thinking it would improve UX a bit by removing it.

Due to the nature of how it's being built at this time ( being filled with input fields upon clicking them) i think this solution is pretty ok.

Removed editable from username
Removed '-' when editing password, so it does not need to be manually removed
Fixed indentation issues.

@mattab mattab added the Needs Review label Apr 24, 2018

@mattab mattab added this to the 3.6.0 milestone Apr 24, 2018

@diosmosis diosmosis merged commit afd7e57 into matomo-org:3.x-dev Jun 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Removed editable from username (matomo-org#12698)
Removed '-' when editing password, so it does not need to be manually removed
Fixed indentation issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.