New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some menus translatable #12885

Merged
merged 2 commits into from Jun 10, 2018

Conversation

Projects
None yet
4 participants
@c960657
Contributor

c960657 commented May 10, 2018

Fix some menu items that are not translatable.

@sgiehl

sgiehl approved these changes May 10, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented May 10, 2018

fyi in theory changing Piwik Mobile App => Mobile_MatomoMobile' is somewhat breaking API so we should at least mention this in the developer changelog.

Why is this breaking API? Developers can hide menus using the menuItem, submenuItem name (translation key). If previously something was removed before based on that specific name, it will no longer work afterwards.

I don't think for those menu items it will be a big deal, but we might need to mention it?

@c960657

This comment has been minimized.

Contributor

c960657 commented May 11, 2018

Ah, I didn't know that. I have added a note to the changelog.

@sgiehl sgiehl added this to the 3.6.0 milestone May 15, 2018

@c960657 c960657 force-pushed the c960657:translate-menu branch 3 times, most recently from 79d1f78 to cb1347d May 22, 2018

@c960657 c960657 force-pushed the c960657:translate-menu branch from cb1347d to 7b02d85 May 29, 2018

@diosmosis diosmosis merged commit 6666479 into matomo-org:3.x-dev Jun 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@c960657 c960657 deleted the c960657:translate-menu branch Jun 11, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Make some menus translatable (matomo-org#12885)
* Make some menus translatable

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment