Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake some menus translatable #12885
Conversation
sgiehl
added
Needs Review
c: i18n
labels
May 10, 2018
This comment has been minimized.
This comment has been minimized.
|
fyi in theory changing Why is this breaking API? Developers can hide menus using the I don't think for those menu items it will be a big deal, but we might need to mention it? |
This comment has been minimized.
This comment has been minimized.
|
Ah, I didn't know that. I have added a note to the changelog. |
sgiehl
added this to the 3.6.0 milestone
May 15, 2018
c960657
force-pushed the
c960657:translate-menu
branch
3 times, most recently
from
79d1f78
to
cb1347d
May 22, 2018
c960657
added some commits
May 10, 2018
c960657
force-pushed the
c960657:translate-menu
branch
from
cb1347d
to
7b02d85
May 29, 2018
diosmosis
merged commit 6666479
into
matomo-org:3.x-dev
Jun 10, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
c960657
deleted the
c960657:translate-menu
branch
Jun 11, 2018
added a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
c960657 commentedMay 10, 2018
Fix some menu items that are not translatable.