Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic device model names if device type is known #13015

Merged
merged 3 commits into from Jun 6, 2018

Conversation

@sgiehl
Copy link
Member

sgiehl commented May 30, 2018

refs #12999

@sgiehl sgiehl added this to the 3.6.0 milestone May 30, 2018
@sgiehl sgiehl force-pushed the genericdevicemodel branch 3 times, most recently from 24c975a to 118587e May 30, 2018
@sgiehl sgiehl force-pushed the genericdevicemodel branch 2 times, most recently from c171f6e to 12e673a May 31, 2018
Copy link
Member

diosmosis left a comment

Some minor comments, otherwise looks good

return 'generic mobile';
}

return '';

This comment has been minimized.

Copy link
@diosmosis

diosmosis Jun 1, 2018

Member

This will also only affect new data, right? Would it be possible to do this during archiving so it can be applied to old reports?

Don't think this is super important if not, though.

This comment has been minimized.

Copy link
@sgiehl

sgiehl Jun 1, 2018

Author Member

It's currently only for new data. Doing that while archiving would be possible but maybe a bit slow, as we would need to run a custom archiving query having an CASE statement to set the generic name based on the device type field... Also it might be a bit weird to have reports showing a generic model, but none can be found with segmentation as the log tables were not updated.
So maybe the correct way would be to write some kind of reattribution script like for geolocation.

This comment has been minimized.

Copy link
@diosmosis

diosmosis Jun 6, 2018

Member

A reattribution script sounds good, though this can always be added later if users require it. Will merge as is.

}
if (!$brand) {
if (!$brand || $brand == Piwik::translate('General_Unknown')) {

This comment has been minimized.

Copy link
@diosmosis

diosmosis Jun 1, 2018

Member

Is $brand == Piwik::translate('General_Unknown' necessary? There's the same check above.

@sgiehl sgiehl force-pushed the genericdevicemodel branch from 12e673a to 1048538 Jun 1, 2018
@diosmosis diosmosis merged commit 5076bd6 into 3.x-dev Jun 6, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diosmosis diosmosis deleted the genericdevicemodel branch Jun 6, 2018
InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
)

* Use generic device model names

* updates tests

* Update screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.