Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes last icon in ImageGraph generated static images shows a wrong icon #13041

Merged
merged 4 commits into from Jun 10, 2018

Conversation

Projects
None yet
4 participants
@fdellwing
Copy link
Contributor

commented Jun 6, 2018

fixes #13039

@fdellwing

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2018

I do not understand why this reusing broke stuff, but this fixxes it.

@sgiehl

This comment has been minimized.

Copy link
Member

commented Jun 6, 2018

Good find. Guess that happens as it is used as reference before: https://github.com/matomo-org/matomo/pull/13041/files#diff-efad25243f722b5c59f5a00f11cf78d9R28

@sgiehl sgiehl added the Needs Review label Jun 7, 2018

@sgiehl sgiehl added this to the 3.6.0 milestone Jun 7, 2018

@diosmosis diosmosis merged commit 061e936 into matomo-org:3.x-dev Jun 10, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@fdellwing fdellwing deleted the fdellwing:fixxes-logo-staticgraph branch Jun 13, 2018

@mattab mattab changed the title Fixxes a problem with preused variable name in graph generating via API Fixes last icon in ImageGraph generated static images shows a wrong icon Aug 28, 2018

@mattab mattab added the Bug label Aug 28, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Fixxes a problem with preused variable name in graph generating via A…
…PI (matomo-org#13041)

* Fixxes a problem with preused variable name in graph generating via API

* Update expected system test files.

* Update expected files again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.