New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure simple datatable metadata is serialized + some test case changes #13296

Merged
merged 3 commits into from Sep 6, 2018

Conversation

Projects
None yet
3 participants
@diosmosis
Member

diosmosis commented Aug 15, 2018

Changes:

  • Make DataTable::$metadata protected so derived classes will end up serializing that property.
  • Allow specifying format in SystemTestCase::runAnyApiTest.
  • Allow specifying test suffix in SystemTestCase::runAnyApiTest.

@diosmosis diosmosis added this to the 3.7.0 milestone Aug 15, 2018

@@ -308,7 +308,7 @@ class DataTable implements DataTableInterface, \IteratorAggregate, \ArrayAccess
*
* @var array
*/
private $metadata = array();
protected $metadata = array();

This comment has been minimized.

@tsteur

tsteur Aug 15, 2018

Member

Could you maybe add a comment so nobody will set it to private later "by accident"? Be good to also have a system test for this (if possible)

This comment has been minimized.

@diosmosis

diosmosis Aug 15, 2018

Member

should be doable to have a test

@diosmosis

This comment has been minimized.

Member

diosmosis commented Aug 20, 2018

@tsteur added test and docs

@diosmosis diosmosis force-pushed the simple-metadata-serialize branch from ced268a to 61f9007 Aug 20, 2018

@diosmosis diosmosis force-pushed the simple-metadata-serialize branch from 61f9007 to 07287f2 Aug 20, 2018

@tsteur

tsteur approved these changes Aug 21, 2018

@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018

@diosmosis diosmosis merged commit f74db0e into 3.x-dev Sep 6, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the simple-metadata-serialize branch Sep 6, 2018

diosmosis added a commit that referenced this pull request Sep 20, 2018

Make sure simple datatable metadata is serialized + some test case ch…
…anges (#13296)

* Make DataTable metadata protected so it will be serialized in derived classes.

* Allow SystemTestCase::runAnyApiTest to test any format and use a testSuffix.

* Add test for metadata serialization & note about it in field docs.

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Make sure simple datatable metadata is serialized + some test case ch…
…anges (matomo-org#13296)

* Make DataTable metadata protected so it will be serialized in derived classes.

* Allow SystemTestCase::runAnyApiTest to test any format and use a testSuffix.

* Add test for metadata serialization & note about it in field docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment