New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember user who created a site. #13362

Merged
merged 8 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@diosmosis
Member

diosmosis commented Aug 29, 2018

No description provided.

@@ -75,6 +75,7 @@ public function getTablesCreateSql()
`group` VARCHAR(250) NOT NULL,
`type` VARCHAR(255) NOT NULL,
keep_url_fragment TINYINT NOT NULL DEFAULT 0,
user_created VARCHAR(100) NULL,

This comment has been minimized.

@tsteur

tsteur Aug 29, 2018

Member

would it be login_created or user_login_created or login_creator or something? In the user table it is the login column that matches it. Might be more clear? not sure...

This comment has been minimized.

@diosmosis

diosmosis Aug 29, 2018

Member

Can change it to creator_login as in "the creator's login"? Was trying to be consistent w/ the ts_created column w/ user_created.

This comment has been minimized.

@tsteur

tsteur Aug 30, 2018

Member

creator_login 👍 I was actually just thinking before the same. otherwise sounds like a user was created

@diosmosis

This comment has been minimized.

Member

diosmosis commented Aug 30, 2018

Updated.

@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018

* @param int $idsite The site ID.
* @return string|null If null, the site was created before the creation user was tracked.
*/
public static function getCreationUserFor($idsite)

This comment has been minimized.

@tsteur

tsteur Sep 7, 2018

Member

Maybe getCreatorLoginFor? For consistency be also good to add a public function getCreatorLogin

@diosmosis diosmosis force-pushed the user-site-creation branch from 2c484b6 to 35837ab Sep 7, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 8, 2018

I presume tests need to be fixed but otherwise looks good to merge.

diosmosis added some commits Sep 10, 2018

@diosmosis diosmosis merged commit fb0d156 into 3.x-dev Sep 10, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@diosmosis diosmosis deleted the user-site-creation branch Sep 10, 2018

diosmosis added a commit that referenced this pull request Sep 20, 2018

Remember user who created a site. (#13362)
* Remember user who created a site.

* Bump version & change column name to creator_login.

* Rename Site::getCreationUserFor

* Process sites like other methods in getPatternMatchSites().

* Update expected test files.

* update test again

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Remember user who created a site. (matomo-org#13362)
* Remember user who created a site.

* Bump version & change column name to creator_login.

* Rename Site::getCreationUserFor

* Process sites like other methods in getPatternMatchSites().

* Update expected test files.

* update test again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment